Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FormData, URLSearchParams and other HTTP classes #208

Closed
6 tasks done
g105b opened this issue May 2, 2023 · 2 comments · Fixed by #212
Closed
6 tasks done

FormData, URLSearchParams and other HTTP classes #208

g105b opened this issue May 2, 2023 · 2 comments · Fixed by #212
Assignees
@g105b
Labels
feature

Comments

@g105b
Copy link
Member

g105b commented May 2, 2023 •
edited
Loading

These two classes are fundamental to basic HTTP usage, but specifically need to be implemented to allow PHP.Gt/Fetch to reach its next stable release.

PhpGt/Fetch#99 relies on this issue.

Class list to implement:
@g105b g105b added the feature label May 2, 2023
@g105b g105b self-assigned this May 2, 2023
@g105b g105b changed the title FormData and URLSearchParams implementation FormData, URLSearchParams and other HTTP classes May 3, 2023
@g105b g105b mentioned this issue May 4, 2023
Merged
@g105b
Copy link
Member Author

g105b commented May 30, 2023 •
edited
Loading

Still need to:

  • test real file uploads
  • implement promise-based returns (that automatically resolve), like Blob::text() for example

g105b added a commit that referenced this issue Jul 1, 2023
@g105b
feature: implement promise-based functions
b9b47d7 
closes #208
@g105b
Copy link
Member Author

g105b commented Jul 1, 2023

The latest commit implements these classes, but the file upload functionality will be handled separately in #213

@g105b g105b closed this as completed Jul 1, 2023
g105b added a commit that referenced this issue Jul 1, 2023
@g105b
Formdata, URLSearchParams (#212)
292e850 
* wip: add formdata class

* wip: add urlsearchparams class

* feature: implement URLSearchParams

* feature: tweak urlsearchparams

* wip: extract KeyValuePairStore

* wip: implement KeyValuePairStore for FormData

* wip: improve tests by expecting warning to be emitted

* wip: empty formdata options

* wip: test submitter is included in the form submission

* wip: test constructing with square brackets

* wip: fix static analysis error on DOMNodeList

* wip: implement form types

* wip: remove unused constants

* feature: implement promise-based functions
closes #208

* test: improve static tests
g105b added a commit that referenced this issue Jul 3, 2023
@g105b
Upload files using FormData (#214)
677c456 
* wip: add formdata class

* wip: add urlsearchparams class

* feature: implement URLSearchParams

* feature: tweak urlsearchparams

* wip: extract KeyValuePairStore

* wip: implement KeyValuePairStore for FormData

* wip: improve tests by expecting warning to be emitted

* wip: empty formdata options

* wip: test submitter is included in the form submission

* wip: test constructing with square brackets

* wip: fix static analysis error on DOMNodeList

* wip: implement form types

* wip: remove unused constants

* feature: implement promise-based functions
closes #208

* test: improve static tests

* wip: uploading of files for #213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Formdata, URLSearchParams PhpGt/Http
1 participant
@g105b