Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NEI.simulate() not return results but rather store results within the class instance? #30

Open
namurphy opened this issue Jun 3, 2020 · 1 comment
Labels

Comments

@namurphy
Copy link
Member

namurphy commented Jun 3, 2020

Comments from code review in #20:

I wouldn't have simulate() return results at all, since that encourages users to separate the results from the originating simulation. I would encourage the use of...

>>> sim.simulate()
>>> sim.results.plot_something()

Or, if the result was a xarray.Dataset then one could do...

>>> sim.simulate()
>>> sim.results.T_e.plot()
@StanczakDominik
Copy link
Member

I'm not sure I agree with the review comment there; I think I like having the simulation object be sort of a set of initial conditions, and then simulate could return an xarray.Dataset of results while allowing one to vary, say, the timestep or other non-physical simulationy parameters. But that's just one approach; I could definitely be convinced otherwise :)

@namurphy namurphy changed the title Make NEI.simulate() not return results but rather store results within the class instance Make NEI.simulate() not return results but rather store results within the class instance? Jun 4, 2020
@github-actions github-actions bot added the Stale label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants