Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also cover non-portable variable names with "non-portable-code" #402

Closed
Sainan opened this issue Nov 11, 2023 · 0 comments · Fixed by #404
Closed

Also cover non-portable variable names with "non-portable-code" #402

Sainan opened this issue Nov 11, 2023 · 0 comments · Fixed by #404
Labels
improvement Improves existing behavior

Comments

@Sainan
Copy link
Member

Sainan commented Nov 11, 2023

For example, if Pluto is built with PLUTO_COMPATIBLE_MODE, the following code is valid but not portable:

new = {}
local class = 1

it should either use pluto_use to guarantee the respective keywords are disabled, or use different variable names.
@Sainan Sainan added the improvement Improves existing behavior label Nov 11, 2023
@Sainan Sainan linked a pull request Nov 11, 2023 that will close this issue
Add non-portable name coverage #404
Merged
@Sainan Sainan closed this as completed Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement Improves existing behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add non-portable name coverage PlutoLang/Pluto
1 participant
@Sainan