Cannot use robot analyzer while FBP is on surgery table

[Neerti]

Description of issue

Using a robot analyzer on an FBP that's on a surgery table makes the game try to use it in a surgery step, and then fail because there is no surgery step for that.

Difference between expected and actual behavior

I expected that using the analyzer on an FBP would attempt to analyze them regardless of being on a surgery table or not. The player being told they can't do anything with the analyzer is pretty misleading and will confuse players who don't know that the You aren't sure what you could do ... string means a failed surgery step, which is bad user experience, in my opinion.

Steps to reproduce

Join as Roboticist.
Acquire an FBP robot.
Rough up the poor innocent robit.
Put them on a surgery table since you might believe that's the intended way to fix FBPs.*
Try to use the robot analyzer so you know which parts you need to fix.
Get told by the game that you're not sure what you could do with the robot analyzer.

• On Polaris code, that is the correct way. Bay/Nebula code might differ on that, but the robot analyzer should work regardless imo, or make it obvious that you're not supposed to use it on a surgery table.

Specific information for locating

When using the analyzer, the player gets told "You aren't sure what you could do to (FBP's name) with the robot analyzer.", which corresponds with https://github.com/PolarisSS13/Polaris-Neb/blob/master/code/modules/surgery/_surgery.dm#L289

Length of time in which bug has been known to occur

Came up when a roboticist adminhelped about not being able to use the analyzer on someone during the test round that occurred tonight as of posting this issue.

Client version, Server revision & Game ID

Current master at time of posting this report, server had shut down before I could use the verb.

Issue bingo

• Issue could be reproduced at least once
• Issue could be reproduced by different players
• Issue could be reproduced in multiple rounds
• Issue happened in a recent (less than 7 days ago) round
• Couldn't find an existing issue about this

[Neerti]

I'm told this also extends to welders, and that having the FBP lie down on a regular table works correctly, but a surgery table doesn't, and it isn't exactly obvious to players that the less fancy table is the correct one to use for fixing robots.

[MistakeNot4892]

That sounds like a broken interaction, not an intentional one. Looking at staging, do_surgery() is only overridden on autopsy scanners. Having a look at fixing it for scanners now, will also check welding tools.

[MistakeNot4892]

Missing entries in global.surgery_tool_exceptions.