Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFrame references the missing class AIMissingCategory #251

Open
olekscode opened this issue Jun 4, 2023 · 2 comments
Open

DataFrame references the missing class AIMissingCategory #251

olekscode opened this issue Jun 4, 2023 · 2 comments

Comments

@olekscode
Copy link
Member

This method requires pharo-ai to be loaded into the image
Which is strange because DataFrame should not depend on AI
So we need to check, maybe it's the method that was accidentally committed here

dataPreProcessingEncodeWith: anEncoder
	"This method is here to speed up pharo-ai/data-preprocessing algos without coupling both projects."

	| copy cache |
	copy := self copy.
	cache := IdentityDictionary new.
	self columns doWithIndex: [ :dataSerie :columnIndex |
		| category |
		category := cache at: columnIndex ifAbsentPut: [ ((anEncoder categories at: columnIndex) collectWithIndex: [ :elem :index | elem -> index ]) asDictionary ].
		dataSerie doWithIndex: [ :element :rowIndex |
			copy at: rowIndex at: columnIndex put: (category at: element ifAbsent: [ AIMissingCategory signalFor: element ]) ] ].

	^ copy
@jecisc
Copy link
Member

jecisc commented Jun 7, 2023

This is my fault indeed :)

I'll add to my todo list to fix this.

@olekscode
Copy link
Member Author

This method should be moved to https://github.com/pharo-ai/data-preprocessing and removed from this repository

jodz4k added a commit to jodz4k/DataFrame that referenced this issue Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants