Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Renamed some properties to match posthog-js #130

Merged
merged 3 commits into from
Dec 4, 2023
Merged

fix: Renamed some properties to match posthog-js #130

merged 3 commits into from
Dec 4, 2023

Conversation

benjackwhite
Copy link
Collaborator

Problem

Someone pointed out that the posthog-js methods aren't available in RN. They are actually there just with slightly outdated naming

Changes

  • Updates the naming to match

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Renamed personProperties to setPersonPropertiesForFlags to match posthog-js and more clearly indicated what it does
  • Renamed groupProperties to setGroupPropertiesForFlags to match posthog-js and more clearly indicated what it does

marandaneto
marandaneto approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benjackwhite benjackwhite merged commit 53400c7 into master Dec 4, 2023
3 checks passed
@benjackwhite benjackwhite deleted the fix/method-naming branch December 4, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@jurajmajerik jurajmajerik jurajmajerik approved these changes

@liyiy liyiy Awaiting requested review from liyiy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benjackwhite @marandaneto @jurajmajerik