-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(flags): Add new debugging property $feature_flag_bootstrapped_response
and $feature_flag_bootstrapped_payload
to $feature_flag_called
event
#320
base: main
Are you sure you want to change the base?
Conversation
…response` and `$feature_flag_bootstrapped_payload` to `$feature_flag_called` event
Size Change: +708 B (+0.65%) Total Size: 109 kB
ℹ️ View Unchanged
|
@dmarticus I'm thinking it may be smart to add an additional property here as well, indicated whether flags have been fetched yet or not at the time of the flag check. Something like |
I love this idea; seems like it couldn't hurt to add this type of metadata to our flags requests – maybe something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stamped with a comment!
@havenbarnes would be cool to add a test case for bootstrap flags and payloads, check the file |
…o chore/bootstrapping-debug-properties
Thanks @marandaneto , added some tests. Also added the |
Problem
When SDK users make use of feature flag bootstrapping, the response shown in the $feature_flag_called event can show different values than what would have been fetched remotely. This can lead to confusion when reviewing flag value breakdown results, for example making it seem as if a flag that is turned completely to
true
was evaluated tofalse
. These two new event properties are mostly useful for debugging customer issues, but could also be used in product to show users that the response shown came from bootstrapped values, and not /decideChanges
Nothing functional, just additional event properties
Release info Sub-libraries affected
Bump level
Libraries affected
Changelog notes
$feature_flag_bootstrapped_response
and$feature_flag_bootstrapped_payload
to$feature_flag_called
event