Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in selectCheckBoxAll method #1848

Open
emilsrits opened this issue Feb 11, 2025 · 0 comments
Open

Typo in selectCheckBoxAll method #1848

emilsrits opened this issue Feb 11, 2025 · 0 comments

Comments

@emilsrits
Copy link

I believe there is a typo here:

It should be hide instead of disable. Currently if hide is active on checkbox rule, then it still gets selected.

Both of these check against disable currently:

$hide = (bool) data_get(
    collect((array) $model->__powergrid_rules) //@phpstan-ignore-line
        ->where('apply', true)
        ->last(),
    'disable',
);

$disable = (bool) data_get(
    collect((array) $model->__powergrid_rules) //@phpstan-ignore-line
        ->where('apply', true)
        ->last(),
    'disable',
);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant