When startAutomatically is false, Plaster command doesn't launch PowerShell session

[mattmcnabb]

System Details

• Operating system name and version: Windows 10

code -v
1.11.1
d9484d12b38879b7f4cdd1150efeb2fd2c1fbf39

$pseditor.EditorServicesVersion
Major  Minor  Build  Revision
-----  -----  -----  --------
0      12     0      0

code --list-extensions --show-versions
chriseckenrode.vscode-chester-atom@0.1.7
donjayamanne.githistory@0.2.0
DotJoshJohnson.xml@1.7.0
eriklynd.json-tools@1.0.2
gerane.Theme-Capo-Light@0.0.3
hdg.live-html-previewer@0.0.1
jprestidge.theme-material-theme@1.0.1
ms-vscode.csharp@1.8.1
ms-vscode.PowerShell@0.12.1
nwallace.createGUID@0.0.2
robertohuertasm.vscode-icons@7.5.1
Shan.code-settings-sync@2.6.2
slevesque.vscode-multiclip@0.1.2

$PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.14393.953
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.953
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Issue Description

When I have "powershell.startautomatically" set to false, a PowerShell session should be launched when certain things take place, but this isn't happening. For instance, when I open a PowerShell script file PowerShell should launch as well. Another case is when I attempt to run the Plaster new project command. Here I receive a message that PowerShell is starting and I should wait, but nothing ever happens:

Attached Logs

Unfortunately, since the PowerShell session doesn't start, there are no logs to gather.

[daviwil]

Thanks Matt! I'll take a look.

[daviwil]

I've been digging around for an old issue I filed related to this but I can't seem to find it. At any rate, I need to come up with a new approach for how the PowerShell session gets launched by commands. It seems that having startAutomatically set to false breaks the behavior of commands that normally would have invoked session startup. This will require a bit of refactoring work so it might need to wait a little while.