Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept HTTP 20x as success, not error #48

Open
PavelVanecek opened this issue Jun 2, 2015 · 1 comment
Open

Accept HTTP 20x as success, not error #48

PavelVanecek opened this issue Jun 2, 2015 · 1 comment

Comments

@PavelVanecek
Copy link

Our server endpoint returns 201 HTTP status code, but filedrop.js considers this as an error and calls the error handler. Given the semantics, this should be considered success and call the file.event("done", ...) listener.

@crabhi
Copy link

crabhi commented Jun 8, 2015

Hi @ProgerXP, @bollwyvl, according to this commit, it seems intentional but I couldn't find any reason why should 2xx responses be considered failures. What was your use case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants