Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModuleImport: Handle failures and edge cases #79

Open
partipan-dot opened this issue Aug 3, 2018 · 0 comments
Open

ModuleImport: Handle failures and edge cases #79

partipan-dot opened this issue Aug 3, 2018 · 0 comments
Labels

Comments

@partipan-dot
Copy link
Collaborator

The ModuleImporter is very naively implemented. It hopes the import succeeds always. The importModule(...) catches IOExceptions and returns null which lead to a NullPointerException in the AsyncTask. The exceptions get logged but the user only sees that the app crashed.

Problems:

  • Check if module imported correctly in AsyncTask iterating over the result (null -> NullPointerException)
  • During import the module lies in a tmp_extraction folder which get renamed afterwards (don't ignore result, it can fail)
  • Handle low space or no space
  • ManifestParser can't handle missing/unknown json attributes (app crashes)
  • The zip can be corrupted or not a zip at all
  • Expected files can be missing in zip
  • Notify user that something went wrong (be specific but user friendy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant