Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong parentFile fileName for mzXML in Windows #3215

Open
JosuaCarl opened this issue Nov 11, 2024 · 2 comments · May be fixed by #3414
Open

Wrong parentFile fileName for mzXML in Windows #3215

JosuaCarl opened this issue Nov 11, 2024 · 2 comments · May be fixed by #3414

Comments

@JosuaCarl
Copy link

JosuaCarl commented Nov 11, 2024

The mzXML files are saved with wrong file delimiters for the parent file, when using Windows. The conversion to mzML worked as expected with the correct delimiters.

With Windows:

                                                        !
<parentFile fileName="file:///D:\folder\tests\test_files/minimal_file.mzXML"
                fileType="processedData"
                fileSha1="4d590e5e85e6ae2eb812f076aa2cef64e0612be5"/>

With Linux:

<parentFile fileName="file:////mnt/d/folder/tests/test_files/minimal_file.mzXML"
                fileType="processedData"
                fileSha1=""/>

I encountered the error when testing, whether the correct input path is saved in the file.

@chambm
Copy link
Member

chambm commented Mar 24, 2025

Which part is wrong? The final forward slash after \test_files? Because backslashes in Windows are correct (but forward slashes work too; mixed slashes can be a problem though).

@JosuaCarl
Copy link
Author

JosuaCarl commented Mar 24, 2025

The problem is that it's mixed, making it hard to parse automatically. It starts with / and ends with \. See the ! where I marked the slash.

Sidenote: Generating a .mzML file always uses the OS's slashing flavor.

@chambm chambm linked a pull request Mar 28, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants