New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw exception when not enough data in builtin javascript ? #12

Open

rom1504 opened this issue Jun 22, 2017 · 2 comments

Member

rom1504 commented Jun 22, 2017

See https://github.com/hansihe/protodefc/blob/master/backend_resources/javascript/builtins.js#L14 vs https://github.com/ProtoDef-io/node-protodef/blob/master/src/datatypes/numeric.js#L67
This is necessary to implement protocols that don't prefix the length (eg minecraft <=1.7)

ghost commented May 31, 2018

How is this checked in normal Node?

Member Author

rom1504 commented May 31, 2018

See the second link I posted here for that (or search for that exception in node-protodef repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment