Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mintDip721 from spec.md is different than mintDip721 from nft/src/service.rs #21

Open
sakunix opened this issue Jan 27, 2022 · 2 comments

Comments

@sakunix
Copy link

sakunix commented Jan 27, 2022

imagen

imagen

@heldrida
Copy link
Member

Hi @sakunix , thanks for reporting. The Nft implementation example ( https://github.com/Psychedelic/DIP721#-nft-implementation-example ) is indeed missing some of the features in the specs; I find that overall, requires a revamp, so I've started looking at it and you'll notice several changes happening in the next few days. Follow development in the develop branch ( https://github.com/Psychedelic/DIP721 ). PRs ( https://github.com/Psychedelic/DIP721/pulls ).

@sakunix
Copy link
Author

sakunix commented Jan 28, 2022

Hi @sakunix , thanks for reporting. The Nft implementation example ( https://github.com/Psychedelic/DIP721#-nft-implementation-example ) is indeed missing some of the features in the specs; I find that overall, requires a revamp, so I've started looking at it and you'll notice several changes happening in the next few days. Follow development in the develop branch ( https://github.com/Psychedelic/DIP721 ). PRs ( https://github.com/Psychedelic/DIP721/pulls ).

very well thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants