Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in readme #4

Open
rem-code-s opened this issue Jan 11, 2022 · 2 comments
Open

Typo in readme #4

rem-code-s opened this issue Jan 11, 2022 · 2 comments

Comments

@rem-code-s
Copy link

rem-code-s commented Jan 11, 2022

I was checking out the DIP721 readme and i think there is a typo, i think this
approveDip721: (user: principal, nat64: token_id) -> (TxReceipt) query;
should be
approveDip721: (user: principal, token_id: nat64) -> (TxReceipt);

Also this function is missing the types i think, cant seem to find it in the code as wel
onDIP721Received: (address caller, address from, uint256 token_id, bytes data) -> ();

@rem-code-s rem-code-s changed the title Typo in readmy Typo in readme Jan 11, 2022
@adamspofford-dfinity
Copy link

Slightly more importantly, it almost certainly shouldn't be query.

@rem-code-s
Copy link
Author

@adamspofford-dfinity you are right, I edited it 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants