Bypass Mob Griefing is Misleading

[PseudoResonance]

Spark link

N/A

Expected behavior

Merriam Webster defines "bypass" as "a shunt," or maybe "to ignore," so I think it's safe to assume that "bypass mob griefing" would mean "regardless of the mobGriefing gamerule, allow this mob to grief."

(I know this is very pedantic...)

Observed/Actual behavior

Mob griefing is toggled, or inverted, because it is XOR'd with mobGriefing.

If bypass mob griefing is true, and mobGriefing is false, the mobs can still grief.
If bypass mob griefing is false, and mobGriefing is true, the mobs CAN NOT grief.

Steps/models to reproduce

1. Set villager bypass mob griefing true
2. Set mobGriefing gamerule true
3. Villagers cannot farm

Purpur version

1.21.4-2407-a14011f (MC: 1.21.4)

Agreements

• I am running the latest version of Purpur available from https://purpurmc.org/downloads.
• I have searched for and ensured there isn't already an open issue regarding this.
• I ticked all the boxes without actually reading them
• My version of Minecraft is supported by Purpur.

Other

I imagine that the intent while programming, was specifically that you can invert the mobGriefing rule on a per-mob basis to get more fine control. I think that's great, it should probably stay? I just think that the specific wording of "bypass" is confusing and may lead others to spend hours trying to figure out why their villagers can't farm... Perhaps it can just be added in some documentation or something. I think "invert" is probably a better way to describe how this config option works, but regardless, I just wanted to post something here so that if anyone else is searching why their villager farm doesn't work, or the villagers won't harvest crops, they can find an answer!

I initially made the discussion at #1646, but was suggested to make an issue too.