-
-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classifier-Free Guidance support #36
Comments
Thanks for the request. As we discussed in private, mirostat support is on the way. After that, we'll focus on a few more deterministic samplers then we can finally move to CFG and grammars. I have not experimented with exllamav2 kernels yet, but I will assume it'll be straightforward enough to migrate from v1 to v2. |
At the moment, we've added support for:
CFG support is not planned and will likely not happen in the foreseeable future, as it slows down generations. |
Re-opening this issue so we can keep track of CFG support. After discussing internally, we decided to add it (but not as a high priority addition). We'll likely need to separate CFG requests to their own unique batches, so the throughput cost doesn't affect regular requests. |
Just saying that as an individual user, having CFG support with 8 bit KV cache is, obviously, really useful. exl2 does this too and it's killer. The net gain for quality feels like it's cheating. I feel it might not even be a bad thing if the negative guidance was, yknow, low quality? It's gotta stay on topic but Not like I'd know. So I'm greatful that you guys do. Keep it up and thanks for your work. |
From yesterday's discussion, here are some extra features to add:
This will help broaden support for newer methods of chatting with models.
The text was updated successfully, but these errors were encountered: