Use helm values to parameterize dev settings #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want these to be managed by helm instead of manually running the `kubectl apply...` commands
Now the PV can get computed dynamically in dev. By default, the PV will be created with a hostpath that's in the root of this project. The user can override that behavior through the use of the `OGDC_PV_HOST_PATH` envvar.
Make clear this resoruce is only used in dev
Let this be managed by helm. Still TODO: require that the password/username be passed in at install-time or pull from some secrets store that ADC/NSIDC have joint access to. Is there something already in place on the ADC k8s?
trey-stafford
force-pushed
the
non-static-dev-hostpath
branch
from
c9cd456 to
e06d98f
Compare
trey-stafford
commented
Dec 19, 2024
There was a problem hiding this comment.
This config has a hard-coded username and password, which I would like to remove. These should be required values provided at helm-execution time.
trey-stafford
commented
Dec 19, 2024
| @@ -1,12 +1,14 @@ | |||
| {{ if eq .Values.ENV "dev" }} | |||
There was a problem hiding this comment.
We'll only apply this PV in dev. In non-dev environments on the ADC k8s cluster, the already-configured CephFS-based PV will be used. Reference on that here: https://github.com/DataONEorg/k8s-cluster/blob/main/storage/storage.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
This same approach can be extended to support non-dev environments. E.g., I would like to update the PVC yaml with whatever config is necessary to enable utilization of the CephFS on the ADC k8s.