Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid creating test files in the project directly #404

Open
cugni opened this issue Sep 10, 2024 · 0 comments
Open

Avoid creating test files in the project directly #404

cugni opened this issue Sep 10, 2024 · 0 comments

Comments

@cugni
Copy link
Member

cugni commented Sep 10, 2024

What went wrong?

As described in the comment of #402, some tests create files in the project directory, which is not ideal because:

  1. It makes the directory messier,
  2. There is a higher chance that one commits these files by mistakes
  3. The tests can be indeterministic, as the results may vary if these files exist.

To avoid this, we should delete the method withSparkAndTmpDir and replace it with withSparkAndTmpWarehouse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant