Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐞] SSR does not list signal effects as qprefetch #7311

Open
wmertens opened this issue Feb 4, 2025 · 0 comments
Open

[🐞] SSR does not list signal effects as qprefetch #7311

wmertens opened this issue Feb 4, 2025 · 0 comments
Assignees
Labels
COMP: performance This issue is related to a performance problem or bug TYPE: bug Something isn't working VERSION: upcoming major

Comments

@wmertens
Copy link
Member

wmertens commented Feb 4, 2025

Which component is affected?

Qwik Runtime

Describe the bug

While running SSR, we keep track of QRL handlers, and we'll instruct the preloader to get those handlers and their import graph.

However, any signals that are written to will have effect qrls, and those aren't listed for preloading.

So we need to keep track of those and add them to the preload list at the end of the container.


Note that Qwik Insights works around this problem because it will learn that clicking that button will change that signal, which will import the component render function.

Also, it would be great if we knew which signals will be written to for a given SSR output, because then we know whether to include effects or not.

@wmertens wmertens added COMP: performance This issue is related to a performance problem or bug TYPE: bug Something isn't working VERSION: upcoming major labels Feb 4, 2025
@wmertens wmertens assigned shairez, wmertens and Varixo and unassigned shairez Feb 4, 2025
@wmertens wmertens moved this from Backlog to Upcoming in Qwik Development Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
COMP: performance This issue is related to a performance problem or bug TYPE: bug Something isn't working VERSION: upcoming major
Projects
Status: Upcoming
Development

No branches or pull requests

3 participants