Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Option for Kaiming He Layer Initialization #53

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Zach-Attach
Copy link

Added a third layer initialization option of kaiming he

Description

Add a third option for weight_init as 'kaiming he' (see https://pytorch.org/docs/stable/nn.init.html and https://arxiv.org/pdf/1803.08494).

Motivation and Context

This change adds additional option for layer initialization, providing more options for the user. In my personal work, I have found this to perform better than orthogonal.

closes #51

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)

Checklist

  • I've read the CONTRIBUTION guide (required)
  • I have updated the changelog accordingly (required).
    • I am unsure if I should actually change the changelogs given how sparse they are.
  • My change requires a change to the documentation.
  • I have updated the tests accordingly (required for a bug fix or a new feature).
    • There are currently no tests in place for layer initialization.
  • I have updated the documentation accordingly.
  • I have opened an associated PR on the rllte-hub repository (if necessary)
  • I have reformatted the code using make format (required)
    • make format formats the code but none of the formats are related to my changes.
  • I have checked the codestyle using make check-codestyle and make lint (required)
  • I have ensured make pytest and make type both pass. (required)
  • I have checked that the documentation builds using make doc (required)

Note: You can run most of the checks using make commit-checks.

Note: we are using a maximum length of 127 characters per line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Addition of Kaiming He Normalization Option for Layer Initialization
1 participant