Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add approprite formatting function for gtests. #3136

Open
CAHEK7 opened this issue Jul 23, 2024 · 2 comments
Open

Add approprite formatting function for gtests. #3136

CAHEK7 opened this issue Jul 23, 2024 · 2 comments
Labels

Comments

@CAHEK7
Copy link
Contributor

CAHEK7 commented Jul 23, 2024

Some of the tests like layernorm (

friend std::ostream& operator<<(std::ostream& os, const AddLayerNormTestCase& tc)
) have a special operator<< for human readable tests case formatting.

A lot of the other cases do not have it and it should be added everywhere.

@CAHEK7 CAHEK7 added the GTest label Jul 23, 2024
@atamazov
Copy link
Contributor

@CAHEK7 If the test case can be unambiguously described by the problem under the test, then we can re-use the serialization function, which should exist in each problem class. What do you think?

@CAHEK7
Copy link
Contributor Author

CAHEK7 commented Jul 23, 2024

@atamazov it will be generalized if the tests are using the same structure for the test cases or the structures are different, but compatible and can be printed via template function.

@CAHEK7 CAHEK7 mentioned this issue Jul 23, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants