Persistent buffers can be given the wrong group permissions

[jsteel44]

It looks like a gid is assumed to be the same as a uid and so my persistent buffers have group rwx given to the wrong group. This could also lead to the chown failing if the gid doesn't exist.

Per-job buffers are unaffected. You can see below the gid is, and should be different to the uid but it incorrectly matches on the persistent buffer.

Example user:

$ id
uid=17121 gid=17124

Buffers:

/dac/2307_job:
total 4
drwxrwx--- 2 17121 17124 4096 Aug  7 12:19 global

/dac/2307_persistent_jsteel:
total 4
drwxrwx--- 2 17121 17121 4096 Aug  7 10:17 global

[JohnGarbutt]

Hmm, I thought this one had been fixed already...
7b66bbf

Need to double check we populate Volume.Group with the correct value.

[jsteel44]

Yes the group chown looks like it is happening but the group is being populated incorrectly. I'll leave that one with you but in case it's any help, here's a stab in the dark:

internal/pkg/dacctl/actions/actions.go: request.Group = request.User

[JohnGarbutt]

After further discussion, we actually need to change how we do the chown etc, it needs to happen on buffer create, not on buffer mount.

[jsteel44]

It looks like a persistent buffer is created with 700 permissions now and group is set to root (at least on the global directory). If that is intended that works for me.

[JohnGarbutt]

Hmm, not sure about the root group. I was expecting it to be what Slurm specified.