Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile for Martin #822

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Add profile for Martin #822

merged 3 commits into from
Nov 20, 2024

Conversation

martinjohndyer
Copy link
Member

Looks okay locally, hopefully all the formatting is correct.

Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

Reminds me I should update mine.

Copy link
Contributor

@ns-rse ns-rse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well, one minor thing I'd be inclined to do to fit with #701 should it ever be merged is to hard wrap long lines at 120 characters the length markdownlint-cli2 is configured to use in that PR.

But that is very minor and I'm not sure #701 will ever see the light of day at this rate! 😆

_people/martin-dyer.md Show resolved Hide resolved
@Robadob
Copy link
Member

Robadob commented Oct 7, 2024

But that is very minor and I'm not sure #701 will ever see the light of day at this rate! 😆

Don't lose hope, it took about 2 years for #446 (#154) to get merged .

@martinjohndyer
Copy link
Member Author

Reads well, one minor thing I'd be inclined to do to fit with #701 should it ever be merged is to hard wrap long lines at 120 characters the length markdownlint-cli2 is configured to use in that PR.

But that is very minor and I'm not sure #701 will ever see the light of day at this rate! 😆

Fair point, I did check some of the other files and there was a mix of wrapped and not. #701 doesn't seem to have changed any of the other files in _people, but I'm happy to edit it if that does go through.

@martinjohndyer martinjohndyer merged commit d56edb2 into master Nov 20, 2024
2 checks passed
@martinjohndyer martinjohndyer deleted the martin_profile branch November 20, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants