Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update your swift package manifest please. #24

Open
jonah-neugass-ck opened this issue Jan 4, 2020 · 1 comment
Open

Update your swift package manifest please. #24

jonah-neugass-ck opened this issue Jan 4, 2020 · 1 comment

Comments

@jonah-neugass-ck
Copy link

Your swift package manifest doesn't work with new versions of Xcode.

@DivineDominion
Copy link
Contributor

Beats me to fix the Package.swift. I think one would have to re-organize the code folder for multi-platform manifests, or change the project to have 1 target for all platforms. That seems to work for ReSwift.

Here's how far I came in my experiments, in case someone wants to pick this up in a PR:

// swift-tools-version:5.1
import PackageDescription

let package = Package(
    name: "ReactiveReSwift",
    products: [
        .library(
            name: "ReactiveReSwift",
            targets: ["ReactiveReSwift-iOS"]),
        .library(
            name: "ReactiveReSwift",
            targets: ["ReactiveReSwift-macOS"]),
        .library(
            name: "ReactiveReSwift",
            targets: ["ReactiveReSwift-tvOS"]),
        .library(
            name: "ReactiveReSwift",
            targets: ["ReactiveReSwift-watchOS"])
    ],
    targets: [
        .target(
            name: "ReactiveReSwift-iOS",
            path: "Sources",
            sources: ["."]
        ),
        .target(
            name: "ReactiveReSwift-macOS",
            path: "Sources",
            sources: ["."]
        ),
        .target(
            name: "ReactiveReSwift-tvOS",
            path: "Sources",
            sources: ["."]
        ),
        .target(
            name: "ReactiveReSwift-watchOS",
            path: "Sources",
            sources: ["."]
        ),

        .testTarget(
            name: "ReactiveReSwift-iOSTests",
            dependencies: ["ReactiveReSwift-iOS"],
            path: "Tests",
            sources: ["."]
        ),
        .testTarget(
            name: "ReactiveReSwift-macOSTests",
            dependencies: ["ReactiveReSwift-macOS"],
            path: "Tests",
            sources: ["."]
        ),
        .testTarget(
            name: "ReactiveReSwift-tvOSTests",
            dependencies: ["ReactiveReSwift-tvOS"],
            path: "Tests",
            sources: ["."]
        ),
        .testTarget(
            name: "ReactiveReSwift-watchOSTests",
            dependencies: ["ReactiveReSwift-watchOS"],
            path: "Tests",
            sources: ["."]
        ),
    ]
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants