Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: option/setting to keep screen awake during the patching process #2400

Closed
3 tasks done
sudoshindo opened this issue Jan 27, 2025 · 7 comments
Closed
3 tasks done
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager

Comments

@sudoshindo
Copy link

Feature description

If the setting is enabled, the phone screen will not sleep during the entire duration of the patching process.

When finished, the screen will be able to go to sleep again.

Motivation

This is a minor but useful convenience feature that will let a user start a patch and keep a close eye on it without manually touching the screen or toggling any quick settings to keep the screen on.

This is typically the way I do patches:

  • start the patch
  • toggle the screen timeout or wakelock/caffeine from the quick settings tiles
  • do something else while keeping an eye on my phone screen

I want to immediately see if an error occurred so I can either retry the patch immediately or report it if necessary. Other wise the amount of time that I didn't notice a problem would be wasted.

I know I described this as being minor, but I hope the reasoning provided is reasonable enough for consideration.

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate.
  • I have chosen an appropriate title.
  • The feature request is only related to ReVanced Manager.
@sudoshindo sudoshindo added the Feature request Requesting a new feature that's not implemented yet label Jan 27, 2025
@oSumAtrIX oSumAtrIX added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jan 29, 2025
@validcube
Copy link
Member

Issue delegated to ReVanced Manager Compose, fixed in

@sudoshindo
Copy link
Author

ETA for next RV Manager release?

@sudoshindo
Copy link
Author

I don't see this in any of the notes on the GitHub releases page

@validcube
Copy link
Member

validcube commented Jan 31, 2025

ETA for next RV Manager release?

We currently don't do ETA to avoid intentionally stress ourselves.

But likely this year (maybe? I hope)

I don't see this in any of the notes on the GitHub releases page

It will be release once we merge it to main branch.

Which can be track by

@sudoshindo
Copy link
Author

next time just skip the haha funny "likely this year"

@kitadai31
Copy link
Contributor

That issue does not exist on the current latest release of ReVanced Manager (v1.23.3).
v1.23.3 keeps screen on during the patching process.

And in the ReVanced Manager Compose (developing version), that issue has been fixed by my pull request.
Why do you have a problem?

@Ushie
Copy link
Member

Ushie commented Jan 31, 2025

next time just skip the haha funny "likely this year"

What? but it is likely this year

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Development

No branches or pull requests

6 participants