From 2aeffd4ba491d38589039d3eb1d16a57211967ea Mon Sep 17 00:00:00 2001 From: superbuggy Date: Wed, 23 Oct 2024 15:55:13 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Correct=20comment.=20This=20is?= =?UTF-8?q?=20a=20combination=20of=202=20commits.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 📝 Improve comment 📝 Improve comment 📝 Correct comment --- cvss40.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cvss40.js b/cvss40.js index 2e026cc..f9b1cac 100644 --- a/cvss40.js +++ b/cvss40.js @@ -22,7 +22,7 @@ * roundToDecimalPlaces(1.005, 2); // returns 1.01 */ function roundToDecimalPlaces(value, decimalPlaces = 1) { - // Step 1: Shift the decimal point by multiplying with 10^decimalPlaces + // Step 1: Shift the decimal point by multiplying with 10^BUFFER_SIZE const BUFFER_SIZE = 5; const factor = Math.pow(10, BUFFER_SIZE); const reRoundFactor = Math.pow(10, decimalPlaces); @@ -35,7 +35,8 @@ function roundToDecimalPlaces(value, decimalPlaces = 1) { // Step 3: Shift the decimal point back by dividing with the same factor const unshiftedValue = (roundedValue / factor); - // Step 4: Re-round the value with an additional buffering step to precent floating point rounding errors in previous step + // Step 4: Re-round the value with an additional buffering step to prevent floating point rounding errors in previous step + // eg. 8.6 - 7.15 will return 1.4499999999999993 rather than 1.45. When this misrepresented, floating-point difference is rounded to one decimal place, this will produce 1.4 which is not correct const reRoundedValue = Math.round(unshiftedValue * reRoundFactor) / reRoundFactor; // Step 5: Ensure the re-rounded has the correct number of decimal places