Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resource importer for FTL files + Better API #1

Closed
RedMser opened this issue Apr 28, 2024 · 0 comments · Fixed by #9
Closed

Resource importer for FTL files + Better API #1

RedMser opened this issue Apr 28, 2024 · 0 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request

Comments

@RedMser
Copy link
Owner

RedMser commented Apr 28, 2024

Check the CSV importer for reference on how to implement this.

  • ResourceFormatLoader: works in game and in editor. Could load .ftl files at runtime.
  • EditorImportPlugin: only works in editor.
    • Variant 1: Saves .translation files like CSV, which would lose FTL data (only keeping messages with empty args) -> this approach does not make sense.
    • Variant 2: Store AST for quicker reconstruction of FTL data (see Investigate binary AST storage #6).

Ideally it should be possible to have multiple FTL files for one language, which can be merged. But neither a requirement, nor am I sure how Godot currently handles multiple Translations for the same locale. Would need to check for conflicting entries as well, or maybe adding multiple bundle files to the same Translation resource...

API should be improved e.g. by removing redundant language ID.

@RedMser RedMser added the enhancement New feature or request label Apr 28, 2024
@RedMser RedMser changed the title Resource importer for FTL files Resource importer for FTL files + Better API Apr 29, 2024
@RedMser RedMser self-assigned this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant