Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WE port: keyboard shortcuts: syntax mappings #884

Open
myrdd opened this issue Jan 10, 2018 · 0 comments
Open

WE port: keyboard shortcuts: syntax mappings #884

myrdd opened this issue Jan 10, 2018 · 0 comments

Comments

@myrdd
Copy link
Member

myrdd commented Jan 10, 2018

Tasks:

Both tasks refer to function _getKeyAttributesFromCombo(aCombo).


Task 1: allow aCombo to be split by either (space) or + (plus sign)

  • if the combo contains at least one plus sign:
    • split the combo by +
  • else:
    • split the combo by (space), as it is done now

Task 2: map WE command modifiers to XUL key modifiers

  • mappings:
    • Ctrl -> accel (yes, sure!)
    • Alt -> alt
    • Command -> accel (I'm quite sure about this)
    • MacCtrl -> control
    • Shift -> shift
  • put the mapping right before this for loop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant