Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a ”status“ page #897

Open
myrdd opened this issue Aug 26, 2018 · 4 comments
Open

create a ”status“ page #897

myrdd opened this issue Aug 26, 2018 · 4 comments

Comments

@myrdd
Copy link
Member

myrdd commented Aug 26, 2018

The status page (about:requestpolicy?status) should contain:

from time to time, more status info can be added to the page, e.g. error logs (compare #5).

@myrdd myrdd added this to the WebExtension port milestone Aug 26, 2018
@shirishag75
Copy link

shirishag75 commented Aug 26, 2018

could you also add to Readme.md that npm is also needed besides nodejs. At least in debian, nodejs and npm are two different packages. Just tried to run 'make' but failed due to npm not being installed.

~/games/requestpolicy$ make
npm install
/bin/bash: npm: command not found
make: *** [Makefile:351: node_modules/.timestamp_packages] Error 127

@myrdd
Copy link
Member Author

myrdd commented Aug 26, 2018

npm is also needed besides nodejs

you're right, I've added it to the readme.

@shirishag75
Copy link

shirishag75 commented Oct 12, 2018

it should also detail also what a typical make run should look like -

~/games/requestpolicy$ make 
npm install
npm WARN tar write after end
npm WARN requestpolicy No repository field.
npm WARN requestpolicy No license field.

added 1310 packages from 804 contributors in 22.022s
touch node_modules/.timestamp_packages
/home/shirish/games/requestpolicy/node_modules/.bin/gulp xpi:nightly
[12:36:49] Using gulpfile ~/games/requestpolicy/gulpfile.js
[12:36:49] Starting 'clean:legacy:nightly'...
[12:36:49] Starting 'versionData:uniqueVersionSuffix'...
[12:36:49] Finished 'clean:legacy:nightly' after 8.47 ms
[12:36:49] Starting 'build:legacy:nightly:copiedFiles'...
[12:36:49] Finished 'versionData:uniqueVersionSuffix' after 30 ms
[12:36:49] Starting 'versionData:uniqueVersion'...
[12:36:49] Finished 'versionData:uniqueVersion' after 77 μs
[12:36:49] Starting 'buildData:legacy:nightly:preprocessContext'...
[12:36:49] Finished 'buildData:legacy:nightly:preprocessContext' after 6.32 ms
[12:36:49] Starting 'build:legacy:nightly:xmlTypePreprocessedFiles'...
[12:36:49] Starting 'build:legacy:nightly:jsTypePreprocessedFiles'...
[12:36:49] Starting 'build:legacy:nightly:js:main'...
[12:36:49] Starting 'build:legacy:nightly:js:embedded-we'...
[12:36:50] Finished 'build:legacy:nightly:xmlTypePreprocessedFiles' after 1.04 s
[12:36:50] Finished 'build:legacy:nightly:js:embedded-we' after 1.02 s
[12:36:51] Finished 'build:legacy:nightly:jsTypePreprocessedFiles' after 1.96 s
[12:36:51] Finished 'build:legacy:nightly:copiedFiles' after 2.51 s
[12:36:53] Finished 'build:legacy:nightly:js:main' after 3.78 s
[12:36:53] Starting 'build:legacy:nightly'...
[12:36:53] Finished 'build:legacy:nightly' after 34 μs
[12:36:53] Starting 'xpi:legacy:nightly'...
[12:36:53] Finished 'xpi:legacy:nightly' after 160 ms
[12:36:53] Starting 'xpi:nightly'...
[12:36:53] Finished 'xpi:nightly' after 5.1 μs

IIUC all the node modules are cached in ~/games/requestpolicy/node_modules

At my end -

~/games/requestpolicy/node_modules$ ls | wc -l
185

@myrdd
Copy link
Member Author

myrdd commented Oct 12, 2018

@shirishag75 please create separate issues for such documentation-related things.

it should also detail also what a typical make run should look like

now documented here:
https://github.com/RequestPolicyContinued/requestpolicy/wiki/Building

btw I've added a sidebar to the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants