Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor change required for Pale Moon 30+ compatibility #913

Open
dawidi opened this issue Mar 21, 2022 · 0 comments
Open

Minor change required for Pale Moon 30+ compatibility #913

dawidi opened this issue Mar 21, 2022 · 0 comments

Comments

@dawidi
Copy link

dawidi commented Mar 21, 2022

The addon's UI components currently do not work on the just-released Pale Moon 30.0.x - it mis-detects the browser as an Australis-based Firefox (because the version number was incremented and the GUID changed back to the one used by Firefox), but that is easy to fix:

In requestpolicy/src/conditional/legacy/content/bootstrap/api/misc-infos.ts at line 34, the test should probably be updated from
public isAustralis: boolean = this.isFirefox && this.vc.compare(this.appinfo.platformVersion, "29") >= 0;
to
public isAustralis: boolean = this.isFirefox && this.isGecko;

For my own usage, I've replaced the test entirely with just false in the xpi without actually rebuilding the addon, and it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant