Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download link and sharing issues #27

Open
andymarden opened this issue Feb 19, 2025 · 2 comments
Open

Download link and sharing issues #27

andymarden opened this issue Feb 19, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@andymarden
Copy link

The local address of where quickdrop is installed is in docker http://techutils.home**:8084**

A download link is made available in this form: http://techutils.home/file/b278da92... the port is missing.

Of course I will put it behind nginx when I have tested it but it needs to have the port if it's non-standard.

BUT - then it will be wrong if behind a reverse proxy - normally apps have the public url included as an env variable which you give to docker at startup - but atm it won't work as far as I can see unless you are http port 80 or https port 443.

Also - the Copy Link button doesn't work (for me) - the buffer is left with what it had before - no copy event happens.

oh - yeah and the link that is to be shared should be file/**download/**b278da92... shouldn't it? Otherwise the consumer will get the buttons to Renew File Lifetime and Share also not to mention one to the admin dashboard! - something I don't want the people I share things with to have access to - only the actual file itself.

In Nginx, I will be putting files/download location with no security and everything else only accessible on the lan (or some other security externally).

Help me with what I am missing or can we get a fix - would really like to start using this - it looks great.

@andymarden andymarden changed the title Download link is missing port Download link and sharing issues Feb 19, 2025
@andymarden
Copy link
Author

Tried going back to 2.6.1 - that's didn't help - same issues. Most bizarre.

FYI - cleint is running kubuntu 24/04- tried Chrome, Edge and Firefox. From Android phone - same thing.

I can't workout what has changed and the logs (or lack of them) aren't helping.

@RoastSlav
Copy link
Owner

QuickDrop is meant to run in a Docker container on port 8080 internally. You map that internal port to whichever external port you prefer, and then use a reverse proxy to handle the external routing. That's why the port isn’t shown in the URL. As for running it without a reverse proxy, I’ll be adding appropriate settings soon to handle that setup properly.

The redirection to the page with the buttons is intentional. If you want a download-only page, you can upload the file with a password and then create an unrestricted share link (accessible via /file/share/), which will only show the download button. The admin dashboard button won’t be visible on that page, and in the next update, there’ll be an option to remove it entirely.

As for the Copy Link button, I just tested it on Firefox 125.0.3 (about a year old, I think) on Ubuntu 22.04.4 LTS, and it worked fine. I usually don’t do much front-end stuff, so maybe there’s some compatibility issue or just JavaScript being weird that I’m not aware of. You say that there aren't logs in the browser?

@RoastSlav RoastSlav added the bug Something isn't working label Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants