Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.11 packages in user channel #339

Closed
lianghongzhuo opened this issue Feb 1, 2023 · 5 comments
Closed

Python 3.11 packages in user channel #339

lianghongzhuo opened this issue Feb 1, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@lianghongzhuo
Copy link
Contributor

lianghongzhuo commented Feb 1, 2023

Thank you for the great framework!
I have built ros linux64 in python3.11 and uploaded it to anaconda. https://anaconda.org/lianghongzhuo/repo
Do you interested in this? How can I contribute?

@lianghongzhuo lianghongzhuo added the bug Something isn't working label Feb 1, 2023
@Tobias-Fischer
Copy link
Collaborator

Awesome, thank you for this!

@wolfv - how should we deal with this?
@lianghongzhuo - a bit of background: so far we tried to limit locally built packages as much as possible, as there are no publicly available build logs etc. in this case. However, I agree that building locally is much easier and pain-free compared to our current CI solution ..

@Tobias-Fischer Tobias-Fischer changed the title how to contribute? Python 3.11 packages in user channel Feb 1, 2023
@lianghongzhuo
Copy link
Contributor Author

By the way, is there a way to set up vinca to generate recipes from the upstream source code? Many patches I made for build python3.11 are just the diff with the upstream source code. If we can build a bleed edge binary then the workload of making patches are reduced.

@Tobias-Fischer
Copy link
Collaborator

Unfortunately not an easy one :(. @wolfv maybe you could point @lianghongzhuo to the right spot in vinca which would enable this?

@lianghongzhuo could you please open a pull request with the additional patches that you used? This would be awesome!

lianghongzhuo added a commit to lianghongzhuo/ros-noetic that referenced this issue Feb 4, 2023
@lianghongzhuo
Copy link
Contributor Author

sure, done.

Tobias-Fischer added a commit that referenced this issue Feb 7, 2023
* patches for python3.11 #339

* Reduce changes

* Create ros-noetic-pybind11-catkin.patch

---------

Co-authored-by: Tobias Fischer <[email protected]>
@Tobias-Fischer Tobias-Fischer added enhancement New feature or request and removed bug Something isn't working labels Apr 17, 2023
@Tobias-Fischer
Copy link
Collaborator

We'll soon release Python 3.11 packages in #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants