Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skewed Brick Causes Lockup and Crash When Added #751

Open
Colassal opened this issue Feb 5, 2025 · 2 comments
Open

Skewed Brick Causes Lockup and Crash When Added #751

Colassal opened this issue Feb 5, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@Colassal
Copy link

Colassal commented Feb 5, 2025

Material Maker version:

Version 1.4a1 and 1.4a2

OS/device including version:

OS: Windows 11
OS REV: 23H2
OS Build Ver: 22631.4751
GPU: Nvidia RTX 3080 10G
GPU Driver Version: 566.36
CPU: i7 14700k (Adding this because i know some software might have issues with how the 12th, 13th, 14th gen cpus work)

Issue description:

Attempted to add node Skewed Bricks to fresh file with no other nodes except the output node. once the skewed brick node is spawned to the grid Material Maker locks up, if the software is interacted with in any way it immediately crashes with no system freezing/greyout.

Steps to reproduce:
Open Material Maker (new material)
Use right click menu or side panel to add Skewed Brick #2
Freeze
Crash

I dont know which log is the right one between godot.log or godot{datetime}.log, but here are my logs:

godot2025-02-05T10.23.38.log:

`Godot Engine v4.3.stable.official.77dcf97d8 - https://godotengine.org Vulkan 1.3.289 - Forward+ - Using Device #0: NVIDIA - NVIDIA GeForce RTX 3080

Cannot open user://export_targets
Loading...





Successfully read library C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/library/base.json
Failed to open user://library/user.json
Successfully read library C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/library/base_brushes.json
Failed to open user://library/user_brushes.json
created thumbnail
(64, 64)
created thumbnail
(64, 64)
created thumbnail
(64, 64)
Setting hdr C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/environments/hdris/epping_forest_01_1k.hdr
USER WARNING: Ignoring unsupported header information in HDR: GAMMA=1.
at: load_image (modules/hdr/image_loader_hdr.cpp:50)
USER WARNING: Ignoring unsupported header information in HDR: PRIMARIES=0 0 0 0 0 0 0 0.
at: load_image (modules/hdr/image_loader_hdr.cpp:50)
USER WARNING: The "move_to_foreground()" method is deprecated, use "grab_focus()" instead.
at: move_to_foreground (scene/main/window.cpp:559)





USER ERROR: Child PopupMenu "Grid" does not exist.
at: add_submenu_item (scene/gui/popup_menu.cpp:1551)`

godot.log

`Godot Engine v4.4.dev7.official.46c8f8c5c - https://godotengine.org Vulkan 1.3.289 - Forward+ - Using Device #0: NVIDIA - NVIDIA GeForce RTX 3080

Cannot open user://export_targets
Loading...
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
Successfully read library C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/library/base.json
Failed to open user://library/user.json
Successfully read library C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/library/base_brushes.json
Failed to open user://library/user_brushes.json
created thumbnail
(64.0, 64.0)
created thumbnail
(64.0, 64.0)
created thumbnail
(64.0, 64.0)
Setting hdr C:/Users/{USERNAME REMOVED}/OneDrive/Desktop/material_maker_1_4a1_windows/environments/hdris/epping_forest_01_1k.hdr
WARNING: Ignoring unsupported header information in HDR: GAMMA=1.
at: load_image (modules/hdr/image_loader_hdr.cpp:50)
WARNING: Ignoring unsupported header information in HDR: PRIMARIES=0 0 0 0 0 0 0 0.
at: load_image (modules/hdr/image_loader_hdr.cpp:50)
WARNING: The "move_to_foreground()" method is deprecated, use "grab_focus()" instead.
at: move_to_foreground (scene/main/window.cpp:586)
THEME UPDATE
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
ERROR: Parameter "shader" is null.
at: get_shader_parameter_list (servers/rendering/renderer_rd/storage_rd/material_storage.cpp:2030)
`

@Colassal Colassal added the bug Something isn't working label Feb 5, 2025
@Colassal Colassal changed the title Skewed Brick #2 Causes Lockup and Crash When Added Skewed Brick Causes Lockup and Crash When Added Feb 5, 2025
@Colassal
Copy link
Author

Colassal commented Feb 5, 2025

Update:

Even though I had used them fine earlier, it seems like ANY pattern that was added was causing a crash.

I deleted the C:\Users{USERNAME}\AppData\Roaming\material_maker_dev folder and relaunched material maker and now they are working so I'm guessing it didn't like something with a setting I had?

I will leave this open for review of logs, otherwise feel free to close.

@RodZill4
Copy link
Owner

RodZill4 commented Feb 6, 2025

Hmm did you update MM to one of the latest dev builds, or just deleted the user directory? I indeed fixed a bug in some of the Bricks nodes, but it should not cause a crash... There may still be a shader generation triggered by this node, but I don't understand how user setup could impact this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants