From ab6c692cfcb8907f1fb5f1df0ba293c6e2325909 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20H=C3=A4rter?= Date: Thu, 6 Feb 2025 07:34:43 +0100 Subject: [PATCH] Issue #4121: Allowed empty values in DF Script config settings. --- Kernel/Modules/AdminDynamicFieldScript.pm | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Kernel/Modules/AdminDynamicFieldScript.pm b/Kernel/Modules/AdminDynamicFieldScript.pm index 561837fab4..74379be24c 100644 --- a/Kernel/Modules/AdminDynamicFieldScript.pm +++ b/Kernel/Modules/AdminDynamicFieldScript.pm @@ -314,21 +314,21 @@ sub _AddAction { Message => Translatable('Need ValidID'), ); } - for my $Arg ( $GetParam{RequiredArgs}->@* ) { + for my $Arg ( grep {$_} $GetParam{RequiredArgs}->@* ) { if ( !$Param{PossibleArgs}{$Arg} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in RequiredArgs.'), ); } } - for my $Trigger ( $GetParam{AJAXTriggers}->@* ) { + for my $Trigger ( grep {$_} $GetParam{AJAXTriggers}->@* ) { if ( !$Param{PossibleAJAXTriggers}{$Trigger} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in PreviewTriggers.'), ); } } - for my $Event ( $GetParam{UpdateEvents}->@* ) { + for my $Event ( grep {$_} $GetParam{UpdateEvents}->@* ) { if ( !$Param{PossibleUpdateEvents}{$Event} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in StorageTriggers.'), @@ -613,21 +613,21 @@ sub _ChangeAction { Message => Translatable('Need ValidID'), ); } - for my $Arg ( $GetParam{RequiredArgs}->@* ) { + for my $Arg ( grep {$_} $GetParam{RequiredArgs}->@* ) { if ( !$Param{PossibleArgs}{$Arg} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in RequiredArgs.'), ); } } - for my $Trigger ( $GetParam{AJAXTriggers}->@* ) { + for my $Trigger ( grep {$_} $GetParam{AJAXTriggers}->@* ) { if ( !$Param{PossibleAJAXTriggers}{$Trigger} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in PreviewTriggers.'), ); } } - for my $Event ( $GetParam{UpdateEvents}->@* ) { + for my $Event ( grep {$_} $GetParam{UpdateEvents}->@* ) { if ( !$Param{PossibleUpdateEvents}{$Event} ) { return $LayoutObject->ErrorScreen( Message => Translatable('Bad value in StorageTriggers.'), @@ -870,7 +870,7 @@ sub _ShowScreen { Class => 'Modernize W75pc Validate_Number', ); - # Selections may be set up in a declaritive way + # Selections may be set up in a declarative way my $FieldType = $Param{FieldType}; if ( $Self->{FieldTypeSettings}->{$FieldType} ) { for my $Setting ( $Self->{FieldTypeSettings}->{$FieldType}->@* ) {