-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to Firefox #2
Comments
I am trying to let Syncia support Firefox, and I made some changes at this branch. Cause Firefox did not allow call of browser API like browser.storage and browser.commands etc direct from the content script, I moved the sidebar to the ide panel from the content script. This change will impact the messaging functions like get-page-content and screenshot, for now I just make read page content function work. Just want to see your opinion about this change. Below is the screenshot about running this tool in Firefox. Thanks. |
Interesting! does it also work on chrome? the sidebar i mean - https://developer.chrome.com/docs/extensions/reference/api/sidePanel |
Nicee, i'll test it out this evening |
The current implementation only covers to chrome. we need to figure out a way to publish the extension to both firefox and chrome with minimal dev effort to preserve maintainability of code.
The text was updated successfully, but these errors were encountered: