Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider uninstall hook #8

Open
ryanbaer opened this issue Feb 7, 2019 · 1 comment
Open

Consider uninstall hook #8

ryanbaer opened this issue Feb 7, 2019 · 1 comment

Comments

@ryanbaer
Copy link

ryanbaer commented Feb 7, 2019

First of all, great project. Was very excited to use it and dug in on cleaning up my import statements. Sadly, couldn't get it to work with create-react-app (tests in particular), so I had to uninstall.

This is just a suggestion to add an uninstall hook (pre- or post-), which clears out the symlinks the package created. It could also perhaps remove the _moduleAliases from the package.json.

As an aside, if you know of a way to make it work with create-react-app, please let me know.
Thanks for your hard work!

@brian428
Copy link

Agreed. Having it clear out the symlinks it created during uninstall would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants