From d97a3b9ca9e119756d6fd9935bfafc8e6eb2b8d9 Mon Sep 17 00:00:00 2001 From: Tony Arcieri Date: Wed, 4 Sep 2024 19:59:34 -0600 Subject: [PATCH] jose-jws: remove broken `url` feature It was never actually declared properly in Cargo.toml and therefore never worked (and therefore this is not actually a breaking change), but also the code behind the feature does not otherwise compile, even if a proper `url` optional dependency is added. --- jose-jws/src/head.rs | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/jose-jws/src/head.rs b/jose-jws/src/head.rs index 9153ba1..fe480a3 100644 --- a/jose-jws/src/head.rs +++ b/jose-jws/src/head.rs @@ -27,11 +27,6 @@ pub struct Protected { #[serde(skip_serializing_if = "Option::is_none", default)] pub crit: Option>, - /// RFC 8555 Section 6.4.1 - #[cfg(feature = "url")] - #[serde(skip_serializing_if = "Option::is_none", default)] - pub url: Option, - /// RFC 8555 Section 6.5.2 #[serde(skip_serializing_if = "Option::is_none", default)] pub nonce: Option, @@ -52,9 +47,6 @@ impl Default for Protected { nonce: None, b64: true, oth: Unprotected::default(), - - #[cfg(feature = "url")] - url: None, } } } @@ -66,11 +58,6 @@ pub struct Unprotected { #[serde(skip_serializing_if = "Option::is_none", default)] pub alg: Option, - /// RFC 7515 Section 4.1.2 - #[cfg(feature = "url")] - #[serde(skip_serializing_if = "Option::is_none", default)] - pub jku: Option, - /// RFC 7515 Section 4.1.3 #[serde(skip_serializing_if = "Option::is_none", default)] pub jwk: Option, @@ -79,11 +66,6 @@ pub struct Unprotected { #[serde(skip_serializing_if = "Option::is_none", default)] pub kid: Option, - /// RFC 7515 Section 4.1.5 - #[serde(skip_serializing_if = "Option::is_none", default)] - #[cfg(feature = "url")] - pub x5u: Option, - /// RFC 7515 Section 4.1.6 #[serde(skip_serializing_if = "Option::is_none", default)] pub x5c: Option, Base64>>>, // base64, not base64url