Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set emap portal password in clearer/safer way #88

Open
jeremyestein opened this issue Feb 26, 2025 · 0 comments
Open

Set emap portal password in clearer/safer way #88

jeremyestein opened this issue Feb 26, 2025 · 0 comments

Comments

@jeremyestein
Copy link
Collaborator

Currently the nginx password is put into the image at build time. This is not great from the point of view of handling secrets — the image could be inadvertently pushed to a container registry, for example.

The password comes from the value you set in ../../config/portal-config-envs. These *-envs files are by convention used for runtime vars, not build time.

So for a start, we could name the vars files better to distinguish between build and run time, otherwise a developer/deployer might assume you can change that variable and it will actually change the password.

But really we should make it so that nginx sets the password at startup time. This all stems from nginx config files being unable to refer to environment variables. There is some workaround involving templating on startup that we should probably implement. Or we could come up with something better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant