From f2720929b265e3373beb3b5bbe47c657659058fa Mon Sep 17 00:00:00 2001 From: Mauro Molinari Date: Tue, 17 Aug 2021 17:54:58 +0200 Subject: [PATCH] Add warning log when ignoring a non-indexed Attribute Consuming Service When a non-indexed Attribute Consuming Service is defined in configuration along with other indexed Services, a warning is printed to the log to inform that the non-indexed one will be ignored. --- .../java/com/onelogin/saml2/settings/SettingsBuilder.java | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/com/onelogin/saml2/settings/SettingsBuilder.java b/core/src/main/java/com/onelogin/saml2/settings/SettingsBuilder.java index 3a807303..3710b77e 100644 --- a/core/src/main/java/com/onelogin/saml2/settings/SettingsBuilder.java +++ b/core/src/main/java/com/onelogin/saml2/settings/SettingsBuilder.java @@ -530,7 +530,13 @@ private List loadAttributeConsumingServices() { // multiple indexed services specified return acsProps.entrySet().stream() // ignore non-indexed service - .filter(entry -> entry.getKey() != -1) + .filter(entry -> { + final boolean indexed = entry.getKey() != -1; + if(!indexed) { + LOGGER.warn("non indexed Attribute Consuming Service found along with other indexed Services; the non-indexed one will be ignored"); + } + return indexed; + }) .map(entry -> loadAttributeConsumingService(entry.getValue(), entry.getKey())) .collect(Collectors.toList()); }