Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AI Core - Git Onboarding #18

Open
lechnerc77 opened this issue Feb 19, 2024 · 1 comment
Open

AI Core - Git Onboarding #18

lechnerc77 opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels
follow-up-with/dev Clarification with development needed. type/content-gaps Something essential is missing in the documentation.

Comments

@lechnerc77
Copy link

Issue description

The section title gives the reader the impression that the generic onboarding of Git repositories independent of the Git offering is described. The text is then more focusing on GitHub, mentions GitLab once, but leaves out GitLab specifics.

The section should clearly state which offerings are supported and then describe the onboarding steps per offering.

In addition, recommending the usage of a PAT is questionable from different aspects. At least for GitHub there should be a GitHub app offered to facilitate the authentication, as the PAT is always bound to a user and that is probably not a good approach in an enterprise context.

Feedback Type (Optional)

other

Page Title on SAP Help Portal (prefilled)

Add a Git Repository

Page URL on SAP Help Portal (prefilled)

https://help.sap.com/docs/sap-ai-core/sap-ai-core-service-guide/register-your-git-repository-and-secrets?version=CLOUD

@karu-0711 karu-0711 self-assigned this Feb 19, 2024
@karu-0711 karu-0711 added follow-up-with/dev Clarification with development needed. type/content-gaps Something essential is missing in the documentation. labels Feb 19, 2024
@karu-0711
Copy link
Contributor

Thank you for your feedback! We’ll look into it and come back to you if we have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow-up-with/dev Clarification with development needed. type/content-gaps Something essential is missing in the documentation.
Projects
None yet
Development

No branches or pull requests

2 participants