You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are a number of places that CombLayer accepts Vec3D points and axes from the command line. Examples include
adding a point tally [-T point free Vec3D(1,2,3) ] or adding an implicit Vec3D e.g source point with [-sdefType point / -sdefObj ObjectName LinkPt].
This is highly inconsistent in naming, method and generalization, and involves significant repeated code ideas if not exact repeats.
Purpose
The objective is to clean this up and provide a single interface and consistent way of specifying all of this.
Proposal / Implementation
In files inputParam.h and inputParamSupport.cxx , functions
These two functions basically can use the Simulation instance to generate points based on FixedComp units or PointMap/SurfMap units.
Currently the possible ways to specify a general point:
Vec3D(x,y,z)
FixedCompName:LinkPt
PointMapName:Name:Index
In the last case, the PointMap can have an optional additional index because multiple points can have a same name as a group. If the index is not given then the first point is the default [specified as 0].
The values in the function are
System :: Standard simulation object
IParam :: input stream from the command line
keyItem :: name of primary flag in the input stream (e.g. the part with - or -- infront of it)
setIndex :: which repeat of the keyItem (starting at 0) to use (e.g. if there are multiple tallies for example)
index :: the start of the variable point in the secondary components in the main field (e.g. -T point Vec3D(x,y,z) woud set index to 1 as if set to zero then we would process "point"
errStr :: Error string to write to place into a throw, if the process fails
Axis / directions are similar (and normalized) and take
Vec3D(x,y,z)
FixedCompName:LinkPt [signed]
SurfMapName:Name:Index
Changes to input
-T point XXX is followed by objOffset / object / offset
This doesnt need to make sense so now we are going with
-T point Vec3DUnit {offset}.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Introduction
There are a number of places that CombLayer accepts Vec3D points and axes from the command line. Examples include
adding a point tally [-T point free Vec3D(1,2,3) ] or adding an implicit Vec3D e.g source point with [-sdefType point / -sdefObj ObjectName LinkPt].
This is highly inconsistent in naming, method and generalization, and involves significant repeated code ideas if not exact repeats.
Purpose
The objective is to clean this up and provide a single interface and consistent way of specifying all of this.
Proposal / Implementation
In files inputParam.h and inputParamSupport.cxx , functions
These two functions basically can use the Simulation instance to generate points based on FixedComp units or PointMap/SurfMap units.
Currently the possible ways to specify a general point:
In the last case, the PointMap can have an optional additional index because multiple points can have a same name as a group. If the index is not given then the first point is the default [specified as 0].
The values in the function are
Axis / directions are similar (and normalized) and take
Changes to input
-T point XXX is followed by objOffset / object / offset
This doesnt need to make sense so now we are going with
-T point Vec3DUnit {offset}.
Beta Was this translation helpful? Give feedback.
All reactions