You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have been working on the X-ray beamline Balder over the last few commits. This has lots of complex vacuum components and in producing new components (e.g. CrossPipe/VacuumBox) etc I have improved the generality of VacuumPipe.
The main features that changed for VacuumPipe are (a) that the flanges can be different sizes. (b) the previous pipe defined a void space outside of the pipe between the outer radius of the flange. I found that this was causing problems for both the different flange sizes and other components in my models that needed to be very close to the pipe, or join into the pipe so I removed it.
I tested this with a number of models in CombLayer BUT VacuumPipe is used by almost everyone and there is a possibility that it will cause your model to break. If so please (a) add a comment below (b) either roll back one or two versions of just VacuumPipe.cxx/h and PipeGenerator.h/cxx if you need a fix in a few hours.
I will endeavour to fix any issues as quickly as possible, i.e. today!
The text was updated successfully, but these errors were encountered:
I have been working on the X-ray beamline Balder over the last few commits. This has lots of complex vacuum components and in producing new components (e.g. CrossPipe/VacuumBox) etc I have improved the generality of VacuumPipe.
The main features that changed for VacuumPipe are (a) that the flanges can be different sizes. (b) the previous pipe defined a void space outside of the pipe between the outer radius of the flange. I found that this was causing problems for both the different flange sizes and other components in my models that needed to be very close to the pipe, or join into the pipe so I removed it.
I tested this with a number of models in CombLayer BUT VacuumPipe is used by almost everyone and there is a possibility that it will cause your model to break. If so please (a) add a comment below (b) either roll back one or two versions of just VacuumPipe.cxx/h and PipeGenerator.h/cxx if you need a fix in a few hours.
I will endeavour to fix any issues as quickly as possible, i.e. today!
The text was updated successfully, but these errors were encountered: