Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite implementation of FastF1 API? #203

Closed
pbulsink opened this issue Nov 12, 2023 · 1 comment
Closed

Rewrite implementation of FastF1 API? #203

pbulsink opened this issue Nov 12, 2023 · 1 comment
Labels
enhancement New feature or request question Further information is requested

Comments

@pbulsink
Copy link
Collaborator

I'm wondering if in the off-season we expand/rewrite some of the capabilities of f1dataR to match the new capabilities of FastF1, and also be more capable of implementing changes to reflect the changes there (#198).

For example, right now, for us to add and fully use pick_drivers instead of using pick_driver takes a rewrite of our get_session_laps() (#78). Had pick_driver() instead been a standalone function (as part of a class or otherwise) it'd be much easier to just accept a vector of character strings or numbers instead of a single value.

I also wonder if having an interface that more closely matches the workflow of FastF1 will make it easier for people to duplicate or expand on analysis they otherwise see happening in Python?

Thoughts?

@pbulsink pbulsink added enhancement New feature or request question Further information is requested labels Nov 12, 2023
@SCasanova
Copy link
Owner

I'm al for it. To be honest the original implementations didn't have much though put into it and I didn't know what the package would turn into. Big fan of rewriting old code

Repository owner locked and limited conversation to collaborators Nov 13, 2023
@pbulsink pbulsink converted this issue into discussion #206 Nov 13, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants