Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Introduction vignette to highlight new features #59

Closed
SCasanova opened this issue Jun 8, 2023 · 11 comments
Closed

Update Introduction vignette to highlight new features #59

SCasanova opened this issue Jun 8, 2023 · 11 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
CRAN Release

Comments

@SCasanova
Copy link
Owner

I have planned to do this for a while but especially now that the session laps function has been added. Also inclusion of other vignettes
@SCasanova SCasanova added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 8, 2023
@pbulsink pbulsink mentioned this issue Jun 13, 2023
Closed
@SCasanova SCasanova changed the title Update Introduction vignette to highnlight new features Update Introduction vignette to highlight new features Jun 19, 2023
@SCasanova
Copy link
Owner Author

Perhaps examples should be added to the functions as well but this can also be done after the 1.0.0 move

@SCasanova
Copy link
Owner Author

SCasanova commented Jun 19, 2023 •
edited
Loading

Will be following this guide (https://combine-australia.github.io/r-pkg-dev/versioning.html) for versioning in the future as I haven't been super consistent with it. Slightly irrelevant but it would be fun to release the 1.0.0 on June 21st (the 1 year anniversary of the package) if you're ok with that.

@pbulsink
Copy link
Collaborator

pbulsink commented Jun 21, 2023 •
edited
Loading

I like it. Package looks great for 1 year!

Thoughts on submitting to CRAN once we hit stable 1.0 and have examples added?

@pbulsink pbulsink mentioned this issue Jun 21, 2023
Closed
@SCasanova
Copy link
Owner Author

Would love to submit to CRAN. I'm a bit nervous about the process but I think we're well on our way

@SCasanova SCasanova added this to the CRAN Release milestone Jun 21, 2023
@pbulsink pbulsink mentioned this issue Jun 24, 2023
Closed
@SCasanova
Copy link
Owner Author

Worked on by #108

@SCasanova
Copy link
Owner Author

What else should we do before CRAN? @pbulsink

@pbulsink
Copy link
Collaborator

pbulsink commented Jul 9, 2023

Likely finish #108, come to a conclusion on #78 (do we need to do multi-driver function or just let the users do it?), look at #113, ensure our version number is correct, and then maybe go for it? If CRAN have additional suggestions after our first submit attempt we can have a better idea of what's needed.

Once submitted we'll have to do PRs to a dev/beta branch because CRAN would prefer updates only happen every few months.

@pbulsink
Copy link
Collaborator

pbulsink commented Jul 9, 2023

Also working in pbulsink/f1dataR:checks-before-cran, so wait for a pr from there?

@SCasanova
Copy link
Owner Author

Yes maybe we can hold off on #78 as it's not necessarily essential. I'm with you on #113

@pbulsink
Copy link
Collaborator

pbulsink commented Jul 9, 2023 via email •
edited by SCasanova
Loading

@pbulsink pbulsink mentioned this issue Jul 10, 2023
Merged
@pbulsink pbulsink mentioned this issue Jul 21, 2023
Closed
@SCasanova
Copy link
Owner Author

Closed by #109, #86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
CRAN Release
Development

No branches or pull requests
2 participants
@pbulsink @SCasanova