Devtest #214
Closed
Devtest #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbulsink
requested changes
Jan 21, 2024
There was a problem hiding this comment.
You've got calls to library() which won't pass CMD check in multi_driver_test.R. In particular the call to tidyverse should be avoided. You'll also have to update all the function calls to other packages to package::function() format.
I'd also add functions and do webpage rebuild as separate PRs just to simplify things, and I'll note you're using an old version of FastF1 in your system, the webpages all had deprecating warnings about using FastF1<3.1
|
Ahh that file wasn't even supposed to be there anymore. I was just trying to test the tests. Disregard this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.