added message tree sorting

Author: ckruse

app/controllers/messages_controller.rb

@@ -2,6 +2,7 @@ class MessagesController < ApplicationController
   def show
     @id = '/' + params[:year] + '/' + params[:mon] + '/' + params[:day] + '/' + params[:tid]
     @thread = CfThread.find_by_id(@id)
+    @thread.sort_tree
 
     @message = @thread.find_message(params[:mid]) if @thread
     raise CForum::NotFoundException.new if @thread.nil? or @message.nil?
@@ -10,6 +11,8 @@ def show
   def new
     @id = '/' + params[:year] + '/' + params[:mon] + '/' + params[:day] + '/' + params[:tid]
     @thread = CfThread.find_by_id(@id)
+    @thread.sort_tree
+
     @parent = @thread.find_message(params[:mid]) if @thread
 
     raise CForum::NotFoundException.new if @thread.nil? or @parent.nil?
@@ -22,6 +25,8 @@ def new
   def create
     @id = '/' + params[:year] + '/' + params[:mon] + '/' + params[:day] + '/' + params[:tid]
     @thread = CfThread.find_by_id(@id)
+    @thread.sort_tree
+
     @parent = @thread.find_message(params[:mid]) if @thread
 
     raise CForum::NotFoundException.new if @thread.nil? or @parent.nil?

app/controllers/threads_controller.rb

@@ -26,6 +26,10 @@ def index
       @threads = CfThread.order('message.created_at' => -1).limit(ConfigManager.setting('pagination') || 10)
     end
 
+    @threads.each do |t|
+      t.sort_tree
+    end
+
     notification_center.notify(SHOW_THREADLIST, @threads)
   end
 

app/models/cf_thread.rb

@@ -21,6 +21,19 @@ def find_message(mid, msg = nil)
 
     nil
   end
+
+  def sort_tree(msg = nil)
+    msg = message if msg.nil?
+
+    unless msg.messages.blank?
+      msg.messages.sort! {|a,b| b.created_at <=> a.created_at }
+
+      msg.messages.each do |m|
+        sort_tree(m)
+      end
+    end
+  end
+
 end
 
 # eof

doc/TODO

@@ -2,7 +2,6 @@ TODO
 
 - avoid duplicates when posting new messages
 - avoid duplicates when posting new threads
-- sort messages
 
 - use scope for archived/not archived instead of querying in the controller index