Avoid logging to the backtrace unconditionally in hot paths.

In case of reading a large group (comparable to entire cache) it accounts
for some non trivial CPU time (cca ~TODO).

Author: alexey-tikhonov

src/db/sysdb_views.c

@@ -1760,7 +1760,10 @@ errno_t sysdb_add_group_member_overrides(struct sss_domain_info *domain,
             }
 
             if (memberuid == NULL) {
-                DEBUG(SSSDBG_TRACE_ALL, "No override name available.\n");
+                if (DEBUG_IS_SET(SSSDBG_TRACE_ALL)) { /* hot path */
+                    DEBUG(SSSDBG_TRACE_ALL, "No override name available for %s.\n",
+                          orig_name);
+                }
                 memberuid = orig_name;
             } else {
                 /* add domain name if memberuid is a short name */
@@ -1784,9 +1787,11 @@ errno_t sysdb_add_group_member_overrides(struct sss_domain_info *domain,
             ret = sysdb_error_to_errno(ret);
             goto done;
         }
-        DEBUG(SSSDBG_TRACE_ALL, "Added [%s] to [%s].\n", memberuid,
-                                OVERRIDE_PREFIX SYSDB_MEMBERUID);
-
+        if (DEBUG_IS_SET(SSSDBG_TRACE_ALL)) { /* hot path */
+            DEBUG(SSSDBG_TRACE_ALL,
+                  "Added [%s] to ["OVERRIDE_PREFIX SYSDB_MEMBERUID"].\n",
+                  memberuid);
+        }
     }
 
     ret = EOK;

src/responder/common/negcache.c

@@ -96,7 +96,9 @@ static int sss_ncache_check_str(struct sss_nc_ctx *ctx, char *str)
     char *ep;
     int ret;
 
-    DEBUG(SSSDBG_TRACE_INTERNAL, "Checking negative cache for [%s]\n", str);
+    if (DEBUG_IS_SET(SSSDBG_TRACE_INTERNAL)) { /* hot path */
+        DEBUG(SSSDBG_TRACE_INTERNAL, "Checking negative cache for [%s]\n", str);
+    }
 
     data.dptr = NULL;
 

src/util/domain_info_utils.c

@@ -910,8 +910,10 @@ static const char *domain_state_str(struct sss_domain_info *dom)
 
 enum sss_domain_state sss_domain_get_state(struct sss_domain_info *dom)
 {
-    DEBUG(SSSDBG_TRACE_LIBS,
-          "Domain %s is %s\n", dom->name, domain_state_str(dom));
+    if (DEBUG_IS_SET(SSSDBG_TRACE_INTERNAL)) { /* hot path */
+        DEBUG(SSSDBG_TRACE_INTERNAL,
+              "Domain %s is %s\n", dom->name, domain_state_str(dom));
+    }
     return dom->state;
 }
 

src/util/usertools.c

@@ -508,8 +508,6 @@ calc_flat_name(struct sss_domain_info *domain)
 
     s = domain->flat_name;
     if (s == NULL) {
-        DEBUG(SSSDBG_FUNC_DATA, "Domain has no flat name set,"
-              "using domain name instead\n");
         s = domain->name;
     }