Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow multiple admin users #208

Closed
wants to merge 5 commits into from
Closed

Allow multiple admin users #208

wants to merge 5 commits into from

Conversation

ricardobranco777
Copy link
Collaborator

@ricardobranco777 ricardobranco777 commented Feb 16, 2023 •
edited
Loading

This PR:

  • Allows the creation of multiple admin users. We no longer need a shared password for the Django superuser. Fixes PCW needs multiple users instead of a single shared admin Django superuser #207
  • Adds createuser to container-startup as we don't need the Django superuser anymore.
  • Creates a different database for authentication. This allows - and forces - us to backup this database to keep the users & passwords.
  • Mitigates the 500 Server Error we're getting because of the use of SQLite. A full fix requires the migration to PostgreSQL.
  • Fixes the use of SECRET_KEY which is supposed to be randomly generated according to the documentation.

Related MR:
https://gitlab.suse.de/qac/publiccloud-qa-suse-de/-/merge_requests/66

@codecov
Copy link

codecov bot commented Feb 16, 2023 •
edited
Loading

Codecov Report

Base: 71.50% // Head: 71.30% // Decreases project coverage by -0.21% ⚠️

Coverage data is based on head (9f4d306) compared to base (778e75b).
Patch coverage: 64.24% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   71.50%   71.30%   -0.21%     
==========================================
  Files          13       13              
  Lines        1130     1150      +20     
==========================================
+ Hits          808      820      +12     
- Misses        322      330       +8
Impacted Files Coverage Δ
ocw/views.py 56.09% <ø> (ø)
webui/urls.py 100.00% <ø> (ø)
ocw/lib/db.py 55.03% <37.09%> (ø)
ocw/models.py 72.04% <50.00%> (ø)
webui/settings.py 91.72% <65.38%> (-5.62%) ⬇️
ocw/tables.py 69.73% <77.77%> (ø)
ocw/lib/EC2.py 74.01% <100.00%> (ø)
ocw/lib/azure.py 69.92% <100.00%> (ø)
ocw/lib/emailnotify.py 67.92% <100.00%> (ø)
ocw/lib/provider.py 87.23% <100.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ricardobranco777 ricardobranco777 added the wip Work in progress label Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asmorodskyi asmorodskyi Awaiting requested review from asmorodskyi

Assignees
No one assigned
Labels
wip Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PCW needs multiple users instead of a single shared admin Django superuser
1 participant
@ricardobranco777