Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files managed by Salt should have a header stating this #148

Open
ypid-geberit opened this issue Oct 1, 2021 · 0 comments
Open

Files managed by Salt should have a header stating this #148

ypid-geberit opened this issue Oct 1, 2021 · 0 comments
Assignees

Comments

@ypid-geberit
Copy link

ypid-geberit commented Oct 1, 2021

Ansible has a variable for this, ansible_managed. Salt does not. I suggest to add "This file is managed by SaltStack, all changes will be lost." in the first few lines of each template that fully manages a file.

Example: https://github.com/SUSE/salt-formulas/blob/master/bind-formula/bind/files/suse/named.conf

Edit: I noticed in the commit messages that you consider yourself not the upstream of the bind formula. From running a diff, I conclude that you consider https://github.com/saltstack-formulas/bind-formula as upstream, but there the SUSE version has custom features that are not upstreamed?

Lets use this https://github.com/SUSE/salt-formulas/blob/master/prometheus-formula/prometheus/files/general-rules.yml as example because with BIND, I should probably fix it upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants